Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue3): use value from v-model (instead of event.target.value) #12368

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(vue3): use value from v-model (instead of event.target.value) #12368

merged 1 commit into from
May 17, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented May 16, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💙 Next Major (30) milestone May 16, 2024
@Antreesy Antreesy requested review from ShGKme and DorraJaouad May 16, 2024 11:15
@Antreesy Antreesy self-assigned this May 16, 2024
ShGKme
ShGKme reviewed May 16, 2024
View reviewed changes
src/App.vue Outdated Show resolved Hide resolved
@ShGKme ShGKme mentioned this pull request May 16, 2024
Merged
@ShGKme

This comment was marked as resolved.

Sign in to view
@Antreesy
fix(NewConversationSetup): use a value passed from v-model
de6f10a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/vue3/sync-to-modelvalue branch from 9f29db6 to de6f10a Compare May 17, 2024 10:07
@Antreesy
Copy link
Contributor Author

Rebased, only fixes are kept

@Antreesy Antreesy changed the title fix(vue3): replace value.sync syntax with v-model syntax fix(vue3): use value from v-model (instead of event.target.value) May 17, 2024
@Antreesy Antreesy requested a review from ShGKme May 17, 2024 10:09
@Antreesy Antreesy merged commit 8346a42 into vue3 May 17, 2024
42 of 43 checks passed
@Antreesy Antreesy deleted the fix/vue3/sync-to-modelvalue branch May 17, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
💬 Talk team
Status: ☑️ Done
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @ShGKme