Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(vue3): remove unecessary keys for v-if #12373

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix(vue3): remove unecessary keys for v-if #12373

merged 1 commit into from
May 24, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
fix(vue3): remove not needed keys
8d93480 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone May 16, 2024
@DorraJaouad DorraJaouad requested review from ShGKme and Antreesy May 16, 2024 15:37
@DorraJaouad DorraJaouad self-assigned this May 16, 2024
@DorraJaouad DorraJaouad merged commit 872fa85 into vue3 May 24, 2024
41 of 44 checks passed
@DorraJaouad DorraJaouad deleted the fix/vue3/unecessary-keys branch May 24, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@DorraJaouad DorraJaouad

Labels
None yet
Projects
💬 Talk team
Status: ☑️ Done
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@DorraJaouad @ShGKme