fix(attachments): allow null expireDate in createShare #12432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
2. developing
regression
feature: upload & shares & voice 📤🎙️
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
If I understand the changes correctly, the public interface always allowed it to be null? Which I would then say needs to be fixed in talk? |
nfebe
reviewed
May 28, 2024
| $share->setSharedWith($shareWith); | ||
| $share->setPermissions($permissions); | ||
|
|
||
| if ($expireDate !== '') { | ||
| if ($expireDate !== null && $expireDate !== '') { |
There was a problem hiding this comment.
empty returns true for both null and empty string ('').
Suggested change
| if ($expireDate !== null && $expireDate !== '') { | |
| if (!empty($expireDate)) { |
There was a problem hiding this comment.
Yes, but I wanted to keep it separated to explicitly show 2 different cases, because '' and null have different semantics here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
expiryDatevalue in server server#44485$expireDateis nownullby default and can be not onlystring🛠️ API Checklist
🚧 Tasks
expireDatenullable and check for null on setting date🏁 Checklist
docs/has been updated or is not required