Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ban): add endpoints for ban handling #12434

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented May 31, 2024

☑️ Resolves

Tip

To test handling a page navigation:

  • create user with id banned
  • create conversation with name ban user
  • try to join as user

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Ban -
image image
List -
image -
image image
Page -
image -

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 6, 2024

We also forgot to add error handling for banned users/guests (but we can merge this first and do a follow-up for the other part):

  • create user with id banned
  • create conversation with name ban user
  • try to join as user
  • you should see 403 Error with response.data.ocs: {"data": { "error": "ban" }}
  • probably we need to redirect to another page (like 404 - Not Found, but specific for 403 / bans)

@Antreesy

This comment was marked as resolved.

@nickvergessen
Copy link
Member

Should be two requests to the server, or could be done with a single entrypoint?

I think I would add the options to the existing endpoint.

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late reply, looks good to me :)
Maybe we could repeat the name instead of referring to "participant" in the checkbox text

Antreesy added 3 commits June 19, 2024 11:00
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/12259/ban-endpoints branch from 546bd3b to c3c27d7 Compare June 19, 2024 12:32
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy marked this pull request as ready for review June 19, 2024 16:15
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🦅

@Antreesy Antreesy merged commit f4d27ca into main Jun 24, 2024
47 of 48 checks passed
@Antreesy Antreesy deleted the feat/12259/ban-endpoints branch June 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants