New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue3] Migrate app to Vue3 #12458

Draft

Antreesy wants to merge 50 commits into main from vue3

+6,445 −6,741

Contributor

Antreesy commented Jun 4, 2024 •

edited

Loading

☑️ Resolves

Ref Vue 3 Migration #9448

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After
Screenshot before	Screenshot after

🚧 Tasks

Remote MediaStream doesn't shown - issue with reactivity
Mapping doesn't stop in the call - from vue3-shortkey, on LocalAudio/Video buttons - https://vueuse.org/core/onKeyStroke/

🏁 Checklist

🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
🖥️ Tested with Desktop client or should not be risky for it
🖌️ Design was reviewed, approved or inspired by the design team
⛑️ Tests are included or not possible
📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Antreesy added 3. to review feature: frontend 🖌️ dependencies labels

Antreesy added this to the 💙 Next Major (30) milestone

Antreesy requested review from ShGKme and DorraJaouad

June 4, 2024 09:38

Antreesy self-assigned this

Antreesy force-pushed the vue3 branch from 51dc9cc to 3f01022 Compare

June 4, 2024 14:40

ShGKme mentioned this pull request

Migrate to Vue 3 nextcloud/talk-desktop#680

Draft

Antreesy force-pushed the vue3 branch from 3f01022 to 6a4ead7 Compare

June 18, 2024 19:59

ShGKme added 20 commits

July 9, 2024 11:52


          chore(vue3): migrate from vue-frag

4043d4d

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): migrate from vue-simple-portal

3f8860a

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(deps): remove unneeded in Vue 3 dependencies

e720792

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(deps): temporary remove @nextcloud/upload

152c5ae

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): temporary disable @nextcloud/upload

53b7398

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(deps): temporary remove @nextcloud/dialogs in Vue 3

1db476f

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): @nextcloud/dialogs - remove styles import

a644baa

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): @nextcloud/dialogs - remove imports

0e18233

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): @nextcloud/dialogs - replace showError

da06f9c

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): @nextcloud/dialogs - replace showSuccess

d0f7332

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): @nextcloud/dialogs - replace showWarning

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): @nextcloud/dialogs - replace showInfo

f99e4fc

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): @nextcloud/dialogs - replace showMessage

38c3df2

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): @nextcloud/dialogs - replace TOAST_*_TIMEOUT

46acc0c

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): @nextcloud/dialogs - remove FilePickerVue

6dc4259

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(deps): upgrade deps to Vue 3 versions

b76f4a0

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): migrate to Vue Router 4

d5c0dd8

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): migrate to Vuex 4

0fc73b3

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): migrate to @vue-leaflet/vue-leaflet

216b48b

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): migrate vue init

6f5dee2

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

DorraJaouad and others added 25 commits

July 9, 2024 11:58


          fix: remove v-on.native modifier

4139f08

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>


          chore(vue3): replace $listeners with explicit emit

40df4bb

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): migrate to ESLint with Vue 3 plugin

00fd413

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): lint vue/no-deprecated-v-bind-sync

3c3e75b

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): lint vue/v-on-event-hyphenation

1b0f2b7

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): lint vue/no-deprecated-destroyed-lifecycle

08bb514

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): lint vue/attributes-order

6125e9a

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          chore(vue3): lint vue/custom-event-name-casing

c4470a0

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): temporary disable nextcloud-vue-collections

4778ff2

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(style): don't pass data-theme-dark

fe882a5

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(NewConversationSetup): use a value passed from v-model

8b409e5

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(vue3): migrate async component registration and remove $children

1f63cdd

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>


          fix(vue3): keep wrapper in transition group for styles

d8e53a1

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>


          fix(vue3): remove not needed keys

186640c

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>


          chore(vue3): migrate to ESLint with Vue 3 plugin

dec067c

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(jest): harden tests with object serializing

04eeaeb

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vue3): fix updated props and attributes

dc5ed8c

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vtu): replace propsData with props

2a97af1

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vtu): replace createLocalVue with plugins, use global mount object

95f8042

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vtu): fix find* utils usage

334fbcc

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vtu): fix text nodes and slots

39c499e

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vue3): fix double emitting

cbe4eb8

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vtu): skip tests for @netxcloud/dialogs and @nextcloud/upload

b71e6dc

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          fix(vtu): replace flushPromises function

c8fef4c

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>


          chore(deps): remove "flush-promises" library

87a3027

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Antreesy force-pushed the vue3 branch from 6a4ead7 to 87a3027 Compare

July 9, 2024 09:59

danxuliu modified the milestones: v20.0.0-beta.1, 💙 Next Beta (30)

nickvergessen modified the milestones: v20.0.0-beta.2, 🖤 Next Major (31)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review dependencies feature: frontend 🖌️