Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NoteToSelf messages are editable forever #13035

Merged
merged 2 commits into from
Aug 22, 2024
Merged

feat: NoteToSelf messages are editable forever #13035

merged 2 commits into from
Aug 22, 2024

Conversation

skalidindi53
Copy link
Contributor

@skalidindi53 skalidindi53 commented Aug 19, 2024 •
edited by nickvergessen
Loading

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • NoteToSelf messages are now editable forever

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@skalidindi53 skalidindi53 self-assigned this Aug 19, 2024
@skalidindi53 skalidindi53 added 2. developing feature: api 🛠️ OCS API for conversations, chats and participants labels Aug 19, 2024
@skalidindi53 skalidindi53 added this to the 💙 Next RC (30) milestone Aug 19, 2024
@skalidindi53 skalidindi53 added the feature: chat 💬 Chat and system messages label Aug 19, 2024
@skalidindi53 skalidindi53 force-pushed the skalidindi53/13033/Keep-NoteToSelf-messages-editable-forever branch 2 times, most recently from bbe4215 to 5f30180 Compare August 19, 2024 20:08
@skalidindi53 skalidindi53 marked this pull request as ready for review August 19, 2024 20:34
@nickvergessen
Copy link
Member

Hmm I guess that means we need frontend and client changes as well?

@skalidindi53 skalidindi53 force-pushed the skalidindi53/13033/Keep-NoteToSelf-messages-editable-forever branch 2 times, most recently from acedb05 to e158ebb Compare August 19, 2024 20:37
@SystemKeeper
Copy link
Contributor

Hmm I guess that means we need frontend and client changes as well?

And a capability …

@skalidindi53
feat: NoteToSelf messages are editable forever
596fd98 
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
@skalidindi53 skalidindi53 force-pushed the skalidindi53/13033/Keep-NoteToSelf-messages-editable-forever branch from e158ebb to 596fd98 Compare August 20, 2024 15:18
nickvergessen
nickvergessen reviewed Aug 22, 2024
View reviewed changes
docs/capabilities.md Outdated Show resolved Hide resolved
@skalidindi53 @nickvergessen
feat: Added capability for editing msgs in NoteToSelf
33374d9 
Signed-off-by: skalidindi53 <s.teja2004@gmail.com>
@nickvergessen nickvergessen force-pushed the skalidindi53/13033/Keep-NoteToSelf-messages-editable-forever branch from 7115301 to 33374d9 Compare August 22, 2024 07:57
@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen nickvergessen merged commit 7f414d3 into main Aug 22, 2024
66 checks passed
@nickvergessen nickvergessen deleted the skalidindi53/13033/Keep-NoteToSelf-messages-editable-forever branch August 22, 2024 08:43
@backportbot backportbot bot mentioned this pull request Aug 22, 2024
Merged
@nickvergessen nickvergessen mentioned this pull request Aug 22, 2024
Closed
@SystemKeeper
Copy link
Contributor

SystemKeeper commented Aug 22, 2024 •
edited
Loading

Adjustment of capability test is missing
Don't mind me...

@SystemKeeper SystemKeeper mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@skalidindi53 skalidindi53

Labels
2. developing feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Keep messages in "Note to self" chat editable forever
3 participants
@skalidindi53 @nickvergessen @SystemKeeper