Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callview: Show internal clients with available video. #13486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

callview: Show internal clients with available video. #13486

wants to merge 1 commit into from
+1 −1

Conversation

fancycode
Copy link
Member

☑️ Resolves

  • Shows video component for internal (SIP-) clients that publish a video stream.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Oct 7, 2024
@fancycode fancycode mentioned this pull request Oct 16, 2024
Open
@fancycode
feat(CallView): Show internal clients with available video.
66cc422 
Signed-off-by: Joachim Bauch <bauch@struktur.de>
@fancycode fancycode force-pushed the support-internal-video branch from 73008a8 to 66cc422 Compare November 19, 2024 07:34
@fancycode
Copy link
Member Author

This is ready for review.

DorraJaouad
DorraJaouad approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
2. developing enhancement feature: SFU & SIP ☎️
Projects
💬 Talk team
Status: 📄 To do (~10 entries)
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@fancycode @DorraJaouad @nickvergessen