Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force call ends after X - API Follow ups #13491

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Force call ends after X - API Follow ups #13491

merged 3 commits into from
Oct 14, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 8, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 2. developing feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls labels Oct 8, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Oct 8, 2024
@nickvergessen nickvergessen self-assigned this Oct 8, 2024
@nickvergessen nickvergessen changed the title Feat/13463/force end call Force call ends after X - API Follow ups Oct 8, 2024
@nickvergessen nickvergessen marked this pull request as draft October 8, 2024 08:18
@nickvergessen
feat(max-duration): Add setupcheck for misconfiguration
646834f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(max-duration): Use a specific end message
784e343 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(max-duration): Add a capability
97de780 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/13463/force-end-call branch from acb3672 to 97de780 Compare October 8, 2024 12:24
@nickvergessen nickvergessen marked this pull request as ready for review October 8, 2024 12:24
@nickvergessen nickvergessen mentioned this pull request Oct 14, 2024
Merged
Antreesy
Antreesy approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setupchecks and updated system messages are tested

@nickvergessen nickvergessen merged commit c5ea96e into main Oct 14, 2024
70 of 71 checks passed
@nickvergessen nickvergessen deleted the feat/13463/force-end-call branch October 14, 2024 13:25
@Antreesy
Copy link
Contributor

Antreesy commented Nov 8, 2024

  • Start a call
  • Reload page to leave it quietly
  • Server sees the number of participants as 0, ends call and posts a falsy message (call duration)
    image

@Antreesy Antreesy mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: settings ⚙️ Settings and config related issues
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Force call ends after X - Follow ups
2 participants
@nickvergessen @Antreesy