Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show conversation settings, if URL hash is specified #13503

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: show conversation settings, if URL hash is specified #13503

merged 1 commit into from
Oct 30, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 9, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

2024-10-09_17h54_21

🏁 Checklist

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 9, 2024
@Antreesy Antreesy requested a review from nickvergessen October 9, 2024 16:01
@Antreesy Antreesy self-assigned this Oct 9, 2024
ShGKme
ShGKme reviewed Oct 10, 2024
View reviewed changes
src/App.vue Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

@Antreesy this still on track?

@Antreesy
fix: listen to dialog triggers from URL hash only when conversation i…
1458a59 
…s open

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/13485/direct-settings branch from 98996ee to 1458a59 Compare October 29, 2024 17:15
nickvergessen
nickvergessen approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should /index.php/apps/spreed/#settings actually open the talk-settings? Not sure it could be useful?

src/views/MainView.vue Show resolved Hide resolved
@nickvergessen
Copy link
Member

/backport to stable30

@Antreesy
Copy link
Contributor Author

Not sure it could be useful?

Unless we have a need, I'd skip it. Otherwise we have OCA.Talk.Settings added recently, which can be used from outside

@Antreesy Antreesy merged commit 5e3c0e5 into main Oct 30, 2024
47 checks passed
@Antreesy Antreesy deleted the feat/13485/direct-settings branch October 30, 2024 09:43
@backportbot backportbot bot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @ShGKme