Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PublicShareSidebar for Nextcloud 31 #13628

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix: PublicShareSidebar for Nextcloud 31 #13628

merged 4 commits into from
Oct 29, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 24, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Oct 24, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 24, 2024
@Antreesy Antreesy self-assigned this Oct 24, 2024
@nickvergessen
Copy link
Member

Failing sharing tests are unrelated and fixed by #13632

@Antreesy Antreesy force-pushed the fix/13402/talk-sidebar-31 branch from 2e58fa4 to 1d675ee Compare October 25, 2024 20:15
DorraJaouad
DorraJaouad reviewed Oct 27, 2024
View reviewed changes
src/PublicShareSidebarTrigger.vue Show resolved Hide resolved
src/PublicShareSidebar.vue Show resolved Hide resolved
src/mainPublicShareSidebar.js Outdated Show resolved Hide resolved
@susnux
Copy link

susnux commented Oct 28, 2024

⚠️ Not sure about the new way of getting shareToken, but previous method is no longer available

In the frontend just use getSharingToken from @nextcloud/sharing/public, this function works with all Nextcloud versions.
Ref: https://nextcloud-libraries.github.io/nextcloud-sharing/functions/public.getSharingToken.html

@Antreesy Antreesy force-pushed the fix/13402/talk-sidebar-31 branch 2 times, most recently from c2a900b to fad342b Compare October 28, 2024 11:58
@Antreesy Antreesy requested a review from DorraJaouad October 28, 2024 14:55
DorraJaouad
DorraJaouad approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 🦅

@Antreesy
chore(deps): install @nextcloud/sharing v0.2.3
4d073cb 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: refactor PublicShareSidebarTrigger
837ca3b 
- replace NcButton with NcHeaderButton
- move to script setup TS
- adjust mountpoint to .header-end

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: refactor PublicShareSidebar
05127b4 
- wrap mounting in function
- adjust shareToken receiving to server API
- adjust mountpoint to #content-vue

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: cleanup styles
f538f9a 
- remove publicshare.css as redundant
- keep footer in place, adjust width if talk sidebar is open

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/13402/talk-sidebar-31 branch from fad342b to f538f9a Compare October 29, 2024 09:08
@Antreesy Antreesy merged commit 8aadc65 into main Oct 29, 2024
69 checks passed
@Antreesy Antreesy deleted the fix/13402/talk-sidebar-31 branch October 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ShGKme ShGKme Awaiting requested review from ShGKme

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Talk sidebar not shown for public shares in Nextcloud 31
4 participants
@Antreesy @nickvergessen @susnux @DorraJaouad