Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TopBarMenu): check capabilities for downloading participants in call #13629

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(TopBarMenu): check capabilities for downloading participants in call #13629

merged 1 commit into from
Oct 25, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
fix(TopBarMenu): check capabilities for downloading participants in call
6d4a49a 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Oct 25, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy October 25, 2024 06:38
@DorraJaouad DorraJaouad self-assigned this Oct 25, 2024
@nickvergessen
Copy link
Member

/backport to stable30

Antreesy
Antreesy approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

src/components/TopBar/TopBarMenu.vue
@@ -381,6 +381,10 @@ export default {
return !this.callViewStore.isEmptyCallView
},

canDownloadCallParticipants() {
return hasTalkFeature(this.token, 'download-call-participants') && this.canModerate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return hasTalkFeature(this.token, 'download-call-participants') && this.canModerate
return hasTalkFeature(this.token, 'download-call-participants') && this.canModerate && this.isInCall

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep it separate so it's visible from the DOM that it's only used in call.

src/components/TopBar/TopBarMenu.vue Show resolved Hide resolved
@DorraJaouad DorraJaouad merged commit 882f02c into main Oct 25, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/download-participants-capabilities branch October 25, 2024 08:39
@backportbot backportbot bot mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @nickvergessen @Antreesy