Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(activity): Fix parameter type of call activity #13719

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 7, 2024

Backport of #13593

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@backportbot backportbot bot added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls labels Nov 7, 2024
@backportbot backportbot bot added this to the 💚 Next Patch (29) milestone Nov 7, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the backport/13593/stable29 branch from 9d77d25 to fa6c521 Compare November 7, 2024 13:35
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing $roomParameter = $this->getFormerRoom($l, (int) $parameters['room']); had failed due to CS change with the spacing on casts

@nickvergessen nickvergessen marked this pull request as ready for review November 7, 2024 13:36
@nickvergessen nickvergessen merged commit d81eddc into stable29 Nov 7, 2024
69 checks passed
@nickvergessen nickvergessen deleted the backport/13593/stable29 branch November 7, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants