Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(activity): Fix parameter type of call activity #13720

Merged
merged 4 commits into from
Nov 7, 2024
Merged

[stable28] fix(activity): Fix parameter type of call activity #13720

merged 4 commits into from
Nov 7, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 7, 2024 •
edited by nickvergessen
Loading

Backport of #13593

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nickvergessen @backportbot
fix(activity): Fix parameter type of call activity
066cacc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@backportbot backportbot bot added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls labels Nov 7, 2024
@backportbot backportbot bot added this to the 🧡 Next Patch (28) milestone Nov 7, 2024
@nickvergessen
fix(activity): Also fix former conversations
058163c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the backport/13593/stable28 branch from f91bc57 to 058163c Compare November 7, 2024 13:38
nickvergessen
nickvergessen approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing $roomParameter = $this->getFormerRoom($l, (int) $parameters['room']); had failed due to CS change with the spacing on casts

@nickvergessen nickvergessen marked this pull request as ready for review November 7, 2024 13:39
@nickvergessen
Copy link
Member

@nickvergessen
ci: Bump CS-Fixer
61b37f4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
ci: Fix CS
8e9695a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit be73841 into stable28 Nov 7, 2024
67 checks passed
@nickvergessen nickvergessen deleted the backport/13593/stable28 branch November 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls
Projects
None yet
Milestone
v18.0.13
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @provokateurin