fix: overwrite EventBus.off method to clear once events #13736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
reviewed
Nov 8, 2024
There was a problem hiding this comment.
I'm not a fun of adding a new function to unsubscribe from a listener. Unlisten shouldn't be different between on and once. It has the same semantics and job. Same for other Event Emitters, including native removeEventListener.
Also, identifying a function by name is not reliable. It can be empty, it can be not unique.
Instead, let's store once handlers in a Map<type, Map<originalHandler, onceHandlers>> and override off method to support new feature.
Antreesy
force-pushed
the
fix/noid/event-bus-once-garbage
branch
from
a13e2ca to
1ca78af
Compare
Antreesy
changed the title
ShGKme
reviewed
Nov 8, 2024
ShGKme
reviewed
Nov 14, 2024
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/noid/event-bus-once-garbage
branch
from
e5ee369 to
a61b1cb
Compare
ShGKme
approved these changes
Nov 14, 2024
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🏁 Checklist