Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] style: fix public share layout #13751

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[stable30] style: fix public share layout #13751

merged 1 commit into from
Nov 11, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • remove empty space reserved for re-parented footer in public share
  • Fixed differently in main branch

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client

@Antreesy
style: remove empty space reserved for re-parented footer in public s…
d0de7c0 
…hare

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 🌠 Next Minor (30) milestone Nov 11, 2024
@Antreesy Antreesy requested a review from DorraJaouad November 11, 2024 10:11
@Antreesy Antreesy self-assigned this Nov 11, 2024
@Antreesy
Copy link
Contributor Author

/backport to stable29

@Antreesy
Copy link
Contributor Author

/backport to stable28

@Antreesy Antreesy merged commit 8901a9d into stable30 Nov 11, 2024
45 checks passed
@Antreesy Antreesy deleted the fix/stable30/public-share-footer branch November 11, 2024 13:16
This was referenced Nov 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v20.1.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad