Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rooms): add option to automatically lock public and group rooms #13779

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Nov 14, 2024

…if they are inactive

Question - do we need to limit the room numbers to a certain amount per run of the BG job?

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@miaulalala miaulalala added 2. developing feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 labels Nov 14, 2024
@miaulalala miaulalala added this to the 🖤 Next Major (31) milestone Nov 14, 2024
@miaulalala miaulalala self-assigned this Nov 14, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable30

@nickvergessen
Copy link
Member

do we need to limit the room numbers to a certain amount per run of the BG job?

Not for now

docs/settings.md Outdated Show resolved Hide resolved
lib/Config.php Outdated Show resolved Hide resolved
lib/Manager.php Outdated Show resolved Hide resolved
lib/BackgroundJob/LockInactiveRooms.php Outdated Show resolved Hide resolved
lib/BackgroundJob/LockInactiveRooms.php Show resolved Hide resolved
lib/Service/RoomService.php Outdated Show resolved Hide resolved
@miaulalala miaulalala marked this pull request as ready for review November 18, 2024 17:29
lib/Manager.php Show resolved Hide resolved
lib/BackgroundJob/LockInactiveRooms.php Show resolved Hide resolved
docs/settings.md Outdated Show resolved Hide resolved
@miaulalala miaulalala marked this pull request as draft November 19, 2024 22:18
@miaulalala miaulalala force-pushed the feat/lock-rooms-after-inactivity branch from 5004c66 to 991be3a Compare November 21, 2024 14:30
@miaulalala miaulalala marked this pull request as ready for review November 21, 2024 14:30
lib/Manager.php Outdated Show resolved Hide resolved
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks

@miaulalala miaulalala force-pushed the feat/lock-rooms-after-inactivity branch from 991be3a to cd8986a Compare November 22, 2024 11:50
@miaulalala miaulalala enabled auto-merge November 22, 2024 11:50
…if they are inactive

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the feat/lock-rooms-after-inactivity branch from cd8986a to f11783e Compare November 22, 2024 11:53
@miaulalala miaulalala merged commit ca877ba into main Nov 22, 2024
71 checks passed
@miaulalala miaulalala deleted the feat/lock-rooms-after-inactivity branch November 22, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Automatic locking of rooms after a certain time of inactivity
2 participants