Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessagesList): fix fetching messages completion when there is no … #13834

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(MessagesList): fix fetching messages completion when there is no … #13834

merged 1 commit into from
Nov 22, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Nov 21, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
chat-before chat-after

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client labels Nov 21, 2024
@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Nov 21, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy November 21, 2024 09:14
@DorraJaouad DorraJaouad self-assigned this Nov 21, 2024
@DorraJaouad DorraJaouad force-pushed the fix/13820/chat-hang-up branch from 3490731 to c93aff7 Compare November 21, 2024 18:12
Antreesy
Antreesy reviewed Nov 21, 2024
View reviewed changes
src/components/MessagesList/MessagesList.vue Outdated Show resolved Hide resolved
src/constants.js Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
src/store/messagesStore.js Outdated Show resolved Hide resolved
@DorraJaouad
fix(MessagesList): fix fetching messages completion when there is no …
9b5af5e 
…message.

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the fix/13820/chat-hang-up branch from c93aff7 to 9b5af5e Compare November 22, 2024 12:10
@Antreesy Antreesy merged commit 83e3b49 into main Nov 22, 2024
47 checks passed
@Antreesy Antreesy deleted the fix/13820/chat-hang-up branch November 22, 2024 12:31
@Antreesy
Copy link
Contributor

/backport to stable30

@backportbot backportbot bot mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Chat UI can "hang" when the chat is completely empty
2 participants
@DorraJaouad @Antreesy