Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): Fix more empty arrays #13837

Merged
merged 9 commits into from
Dec 2, 2024
Merged

fix(openapi): Fix more empty arrays #13837

merged 9 commits into from
Dec 2, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 21, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen marked this pull request as draft November 21, 2024 13:42
@nickvergessen nickvergessen force-pushed the openapi/noid/room-stuff branch from 3747a6f to 5982abb Compare November 28, 2024 10:12
@nickvergessen nickvergessen self-assigned this Nov 28, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Nov 28, 2024
@nickvergessen nickvergessen marked this pull request as ready for review November 28, 2024 10:13
@nickvergessen nickvergessen changed the title Openapi/noid/room stuff fix(openapi): Fix more empty arrays Nov 28, 2024
@nickvergessen
fix(openapi): Fix poll returned lists
288ade6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix chat API list behaviour
a9be075 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix always empty data response of public share auth
05b8e72 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix reactions API empty array cases
563b2f6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix empty array cases for room controller used by clients
451ad1e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix empty array for SIP integration
62f1cce 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Fix empty array on capabilities
df04571 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(openapi): Regenerate OpenAPI assets
91fd4b9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the openapi/noid/room-stuff branch from 5982abb to 91fd4b9 Compare November 28, 2024 11:00
@nickvergessen nickvergessen mentioned this pull request Nov 28, 2024
Merged
3 tasks
@nickvergessen
Copy link
Member Author

The type on the capabilities changed (from array{spreed: array{…}}|array<empty> to array{spreed?: …}
And now Jest is failing. Could you have a look @DorraJaouad ?

miaulalala
miaulalala approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antreesy
fix(jest): adjust incoming types in CapabilitiesManager
1e3a566 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@DorraJaouad
Copy link
Contributor

The type on the capabilities changed (from array{spreed: array{…}}|array<empty> to array{spreed?: …} And now Jest is failing. Could you have a look @DorraJaouad ?

Sorry, I missed the notification for this 👀

@nickvergessen nickvergessen merged commit f7aab2a into main Dec 2, 2024
71 checks passed
@nickvergessen nickvergessen deleted the openapi/noid/room-stuff branch December 2, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy left review comments

@miaulalala miaulalala miaulalala approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @DorraJaouad @miaulalala @Antreesy