feat(polls): allow editing of draft polls #13883
Open
+1,144
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen wdyt of adding the validation to the setters in the Poll Entity instead of validating them beforehand? Would make sense, don't you think? |
nickvergessen
added
2. developing
feature: api 🛠️
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
8e473b0 to
9dcf018
Compare
nickvergessen
requested changes
Dec 6, 2024
Signed-off-by: Anna Larch <anna@nextcloud.com> # The commit message #2 will be skipped: # fixup! feat(polls): allow editing of draft polls
miaulalala
force-pushed
the
feat/edit-delete-poll-drafts
branch
from
2aeb3ef to
0ca00dd
Compare
lib/Controller/PollController.php
Outdated
| try { | ||
| $poll = $this->pollService->getPoll($this->room->getId(), $pollId); | ||
| } catch (DoesNotExistException $e) { | ||
| return new DataResponse(['error' => $e->getMessage()], Http::STATUS_NOT_FOUND); |
There was a problem hiding this comment.
Suggested change
| return new DataResponse(['error' => $e->getMessage()], Http::STATUS_NOT_FOUND); | |
| return new DataResponse(['error' => PollPropertyException::REASON_POLL], Http::STATUS_NOT_FOUND); |
There was a problem hiding this comment.
This gives me a MoreSpecificReturnType error, same with the change below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required