Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect user changes of devices state when toggling it #13892

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Nov 28, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before
If you have default device state to be off and you toggle either audio or video on before joining the call, your changes won't be considered

🏡 After
If you have default device state to be off and you toggle either audio or video on before joining the call, your changes will be considered

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

…tings

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Nov 28, 2024
@DorraJaouad DorraJaouad self-assigned this Nov 28, 2024
@DorraJaouad DorraJaouad changed the title fix: respect user changes of devices state when toggling in media set… fix: respect user changes of devices state when toggling it Nov 28, 2024
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we should store enabled and disabled, so that we could know if the user enabled it already in a conversation at some point and not always disable it. So that it is a real "default", not a "force"

@nickvergessen nickvergessen merged commit 3044c0b into main Nov 28, 2024
47 checks passed
@nickvergessen nickvergessen deleted the fix/default-devices-state-behavior branch November 28, 2024 14:09
@nickvergessen
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants