Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ooo): Add start and end dates to out-of-office view #13922

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feat(ooo): Add start and end dates to out-of-office view #13922

merged 2 commits into from
Dec 2, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 2, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Eng locale Other locale
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 2, 2024
@Antreesy Antreesy self-assigned this Dec 2, 2024
nickvergessen
nickvergessen approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are not happy, but looks good

DorraJaouad
DorraJaouad approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just the path in tests.

@Antreesy
fix(ooo): add typings for out-of-office response
59652a9 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat(ooo): show absence period
c449e68 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12406/ooo-response branch from 8683e5d to c449e68 Compare December 2, 2024 13:53
@Antreesy Antreesy merged commit 9bfd8a4 into main Dec 2, 2024
47 checks passed
@Antreesy Antreesy deleted the fix/12406/ooo-response branch December 2, 2024 14:22
@nickvergessen
Copy link
Member

/backport to stable30

@backportbot backportbot bot mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad