Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SettingsDialog): check capability for start without media #13952

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix(SettingsDialog): check capability for start without media #13952

merged 2 commits into from
Dec 6, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad
fix: cleanup
ab61d89 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: wrap with capability check
4f8a3fe 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added this to the 🖤 Next Major (31) milestone Dec 6, 2024
@DorraJaouad DorraJaouad requested a review from Antreesy December 6, 2024 12:38
@DorraJaouad DorraJaouad self-assigned this Dec 6, 2024
@DorraJaouad
Copy link
Contributor Author

/backport to stable30

@DorraJaouad DorraJaouad merged commit b74785b into main Dec 6, 2024
47 checks passed
@DorraJaouad DorraJaouad deleted the fix/957/check-capabilities-in-start-without-media branch December 6, 2024 13:57
@backportbot backportbot bot mentioned this pull request Dec 6, 2024
Merged
@Antreesy Antreesy mentioned this pull request Dec 10, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
bug feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
2 participants
@DorraJaouad @Antreesy