fix(call): Fix call notification when being pinged again after leavin… #13979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a call Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
bug
feature: api 🛠️
miaulalala
approved these changes
Dec 11, 2024
Antreesy
approved these changes
Dec 11, 2024
nickvergessen
deleted the
bugfix/13966/call-notification-for-ringing-someone-again
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g a call
☑️ Resolves
Fix #13966
The participant had joined the call, but left again.
In this case we should not ring any more, but clients stop
pinging the endpoint 45s after receiving the push anyway.
However, it is also possible that the participant was ringed
again by a moderator after they had joined the call before.
So if a client pings the endpoint after 45s initial ringing
+ 15 seconds for worst case push notification delay, we will
again tell them to show the call notification.
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required