fix(SpeakingWhileMutedWarner): show toast message #14023
Merged
+16
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tooltip Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
|
/backport to stable30 |
|
/backport to stable29 |
ShGKme
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
There was a problem hiding this comment.
@Antreesy this used to be a tooltip pointing nicely to the mute/unmute button, would that be possible to do again?
Alternatively, we can shorten the text and include a button:
You seem to be talking while muted [Unmute]
Sounds good, but I won't rush with it for today's release (as we don't have translations). Will come back to it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
thisand therefore it wasn't easy to track changes when moved to a new component🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏡 After
🏁 Checklist