Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): Paginate unified search results #14024

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(search): Paginate unified search results #14024

merged 1 commit into from
Dec 19, 2024
+153 −22

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 19, 2024 •
edited
Loading

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

  • Notify clients

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: search 🔎 labels Dec 19, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Dec 19, 2024
@nickvergessen nickvergessen self-assigned this Dec 19, 2024
@nickvergessen
fix(search): Paginate unified search results
fc3779c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/14011/paginate-search-results branch from 80fcb91 to fc3779c Compare December 19, 2024 09:33
@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen
Copy link
Member Author

/backport to stable28

SystemKeeper
SystemKeeper approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Tested with Unified Search and Smart Picker, both seem to work fine.

Thanks for adding the comments.

miaulalala
miaulalala approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@nickvergessen nickvergessen merged commit 681e2d4 into main Dec 19, 2024
75 checks passed
@nickvergessen nickvergessen deleted the bugfix/14011/paginate-search-results branch December 19, 2024 12:54
This was referenced Dec 19, 2024
Draft
Draft
Merged
@juliusknorr juliusknorr mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@SystemKeeper SystemKeeper SystemKeeper approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: search 🔎
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.

Support pagination for search provider
3 participants
@nickvergessen @SystemKeeper @miaulalala