Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): Expose the "top most parent" ID as thread ID #9830

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 21, 2023

☑️ Resolves

🚧 Tasks

  • Add threading system
    • Expose top most parent id as thread id
  • Define capability
  • Adjust documentation

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not required
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Jun 21, 2023
@nickvergessen nickvergessen added this to the 💜 Next Major (28) milestone Jun 21, 2023
@nickvergessen nickvergessen self-assigned this Jun 21, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feat/9679/api-for-threads branch from 91201e1 to 5af43cd Compare June 22, 2023 08:16
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to receive from web client, message by default gets threadId=0, 1-st level replies get the same threadId as parent param, deep replies inherit threadId of the original first message

Note: at the moment thread messages would look messy in the original message list. Also in order to show threads, we need to receive all messages by threadId, including the original one (by id), and also all the original thread messages (which have thread started - maybe, additional param?)

@nickvergessen
Copy link
Member Author

at the moment thread messages would look messy in the original message list.

As per last team week we will only add an option to filter for a thread, we will not restructure the messages list into a thread list making it very easy to miss messages.

Also in order to show threads, we need to receive all messages by threadId, including the original one (by id), and also all the original thread messages (which have thread started - maybe, additional param?)

Thought about this too, but we just filter the existing message list, so the existing API should work in most cases?

@nickvergessen nickvergessen merged commit ca29fbb into master Jun 26, 2023
@nickvergessen nickvergessen deleted the feat/9679/api-for-threads branch June 26, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

API - Message threads
2 participants