-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store) replace Vuex settingsStore
with equivalent Pinia store
#9892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we also need to init Pinia at least in files sidebar app. And then we will need to init pinia in other apps used store.
All the other things looks great to me.
While I believe, moving to Pinia has only benefits and no drawbacks, I'm not sure we should do it now (as was discussed with @nickvergessen on the Talk Team week).
This is not a part of Vue 3 migration as both Pinia and Vuex are not linked to a specific Vue version. We can do it before the migration as well as after the migration.
Nevertheless, I'm personally fine to move to Pinia any time.
19d3eca
to
d9c42f6
Compare
d9c42f6
to
578e5bf
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
578e5bf
to
ec5dd42
Compare
Rebased onto master because of conflicting package-lock.json Also reverted prevously discussed changes regarding storing the capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍍 Tested, works fine 🍍
Note, OptionsApi-like define store was used here. It is easier for migration purpose and looks more structured. But CompositionApi-like defineStore have more possibilities, such as:
- More complex init
- Internal (aka private) methods and variables
- Possibility to use
watch
and etc.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
docs/
has been updated or is not required