enh: improve props

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
nextcloud · Feb 13, 2024 · 2c60436 · 2c60436
1 parent 2ce0601
commit 2c60436
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/modules/modals/DeleteRows.vue b/src/modules/modals/DeleteRows.vue
@@ -26,14 +26,22 @@ export default {
 			type: Array,
 			default: null,
 		},
+		elementId: {
+			type: Number,
+			default: null,
+		},
+		isView: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	methods: {
 		deleteRows() {
 			let error = false
-			this.rowsToDelete.rows.forEach(rowId => {
+			this.rowsToDelete.forEach(rowId => {
 				const res = this.$store.dispatch('removeRow', {
 					rowId,
-					viewId: this.rowsToDelete.isView ? this.rowsToDelete.elementId : null,
+					viewId: this.isView ? this.elementId : null,
 				})
 				if (!res) {
 					error = true
@@ -42,7 +50,7 @@ export default {
 			if (error) {
 				showError(t('tables', 'Error occurred while deleting rows.'))
 			}
-			emit('tables:selected-rows:deselect', { elementId: this.rowsToDelete.elementId, isView: this.rowsToDelete.isView })
+			emit('tables:selected-rows:deselect', { elementId: this.elementId, isView: this.isView })
 			this.$emit('cancel')
 		},
 	},

diff --git a/src/modules/modals/Modals.vue b/src/modules/modals/Modals.vue
@@ -19,7 +19,7 @@
 			:show-modal="editRow !== null"
 			:out-transition="true"
 			@close="editRow = null" />
-		<DeleteRows v-if="rowsToDelete" :rows-to-delete="rowsToDelete" @cancel="rowsToDelete = null" />
+		<DeleteRows v-if="rowsToDelete" :rows-to-delete="rowsToDelete?.rows" :is-view="rowsToDelete?.isView" :element-id="rowsToDelete?.elementId" @cancel="rowsToDelete = null" />
 
 		<ViewSettings
 			:show-modal="viewToEdit !== null"