Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for teams in usergroup column #1326

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Aug 29, 2024

Fixes #1304

@enjeck enjeck self-assigned this Aug 29, 2024
@enjeck enjeck added the 2. developing Work in progress label Aug 29, 2024
@juliusknorr juliusknorr added the enhancement New feature or request label Aug 29, 2024
@enjeck enjeck force-pushed the feat/1304 branch 2 times, most recently from cced61d to a4cf3b0 Compare September 4, 2024 07:43
@enjeck enjeck marked this pull request as ready for review September 4, 2024 07:43
@enjeck enjeck added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 4, 2024
@enjeck
Copy link
Contributor Author

enjeck commented Sep 4, 2024

Demo

2024-09-04_08-24-21.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I verify that this migration works? I try using a different tables branch initially, then switch to this afterwards. But these changes aren't applied automatically

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a version bump, and the databse in the previous stage. If the migration ran before, you also have to remove it from the oc_migrations table.

@enjeck enjeck force-pushed the feat/1304 branch 2 times, most recently from 98fa8eb to daed40a Compare October 2, 2024 15:08
@enjeck enjeck force-pushed the feat/1304 branch 2 times, most recently from a2bb27a to 42b32dc Compare October 23, 2024 18:08
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

Successfully merging this pull request may close these issues.

Add support for teams in the user/group column
3 participants