enh: display error popup when import preview fails #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjeck
added
3. to review
|
Definitely an improvement! Maybe we still can do update this screen as well?
Cause it keep idling and the notification on the top right may escape the eye. |
|
Agreed, let's switch to a proper error screen |
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
show-preview-import-error
branch
from
71438d9
to
10bd6a9
Compare
|
Now, it shows this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, at #1440, when the import fails, there's no error visible to the user. So, this adds an error popup so the user knows that there was a problem