Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "start of week" filter not working on table views #1476

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

burdoto
Copy link
Contributor

@burdoto burdoto commented Nov 25, 2024

Tested this on a Nextcloud v30 instance. Works just fine, "start of week" no longer shows everything.

Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you, I tested and it works. One request:

lib/Db/Row2Mapper.php Show resolved Hide resolved
Signed-off-by: Kaley <kaleidox@comroid.org>
Signed-off-by: Kaley <kaleidox@comroid.org>
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@enjeck enjeck merged commit 9ea4efb into nextcloud:main Nov 27, 2024
63 checks passed
@juliusknorr juliusknorr added the bug Something isn't working label Nov 27, 2024
@burdoto burdoto deleted the patch-2 branch December 6, 2024 15:05
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@burdoto
Copy link
Contributor Author

burdoto commented Dec 17, 2024

Hi, I have noticed that upon updating to Nextcloud 30.0.4, Tables was updated to version 0.8.2; but shipped without this fix.

@enjeck
Copy link
Contributor

enjeck commented Dec 21, 2024

Hi, I have noticed that upon updating to Nextcloud 30.0.4, Tables was updated to version 0.8.2; but shipped without this fix.

Ah, we didn't backport this

@enjeck
Copy link
Contributor

enjeck commented Dec 21, 2024

/backport to stable0.8

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Dec 21, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Dec 21, 2024
@enjeck
Copy link
Contributor

enjeck commented Dec 21, 2024

@burdoto It'll be in 0.8.3. Thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants