fix(TextEditor): reset the editor, if an empty value is set #510
Conversation
- for example if the modal was resetted Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
|
@juliushaertl any comments on this or could you approve? |
| // reset editor if content is empty | ||
| // otherwise the (empty) content will not be updated | ||
| if (value === '') { | ||
| this.setupEditor() |
There was a problem hiding this comment.
Make sure to destroy possibly existing instances using this before:
this?.editor?.destroy()
There was a problem hiding this comment.
this is what happens first in method this.setupEditor(), why do I have to do it before twice?
There was a problem hiding this comment.
Ah sorry, then I misread the diff somehow
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
|
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
closes #459