Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/529 Search for tables and views #533

Merged
merged 10 commits into from
Sep 12, 2023
Merged

Fix/529 Search for tables and views #533

merged 10 commits into from
Sep 12, 2023

Conversation

datenangebot
Copy link
Collaborator

@datenangebot datenangebot commented Sep 11, 2023

closes #529
closes #528

searching for tables was missing 🙄

Florian Steffens added 2 commits September 11, 2023 12:31
- add search for tables
- small code cleanups

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
- test for views
- test for tables

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@datenangebot datenangebot added this to the v0.6.0 milestone Sep 11, 2023
@datenangebot datenangebot enabled auto-merge (squash) September 11, 2023 11:08
@datenangebot
Copy link
Collaborator Author

datenangebot commented Sep 11, 2023

@datenangebot datenangebot changed the title Fix/529 Fix/529 Search for tables and views Sep 11, 2023
Florian Steffens added 2 commits September 11, 2023 21:11
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Florian Steffens added 3 commits September 11, 2023 22:50
…shared via a group)

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@datenangebot
Copy link
Collaborator Author

datenangebot commented Sep 11, 2023

  • Test for a shared view
  • Test for a shared table via group sharing
  • Test for a shared view via group sharing

@juliushaertl Could need some help here. There is no request for my tables search provider. Locally all works fine.

- fix psalm errors

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@datenangebot datenangebot force-pushed the fix/529 branch 5 times, most recently from d69eb12 to c8d6359 Compare September 12, 2023 06:48
- test for views
- test for tables
- cleanup

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@juliusknorr
Copy link
Member

Ah seems you found it already. Just to have it mentioned (maybe you figured it out that way as well). The logs + screenshots are uploaded as assets on the cypress run https://github.com/nextcloud/tables/actions/runs/6156012270?pr=533

The logs then also show the composer autoload error

@juliusknorr juliusknorr merged commit 3f63c14 into main Sep 12, 2023
16 checks passed
@juliusknorr juliusknorr deleted the fix/529 branch September 12, 2023 07:52
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not search for tables Can not find shared tables/views in widget config
2 participants