-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/529 Search for tables and views #533
Conversation
- add search for tables - small code cleanups Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
- test for views - test for tables Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
|
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
…shared via a group) Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
@juliushaertl Could need some help here. There is no request for my tables search provider. Locally all works fine. |
- fix psalm errors Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
d69eb12
to
c8d6359
Compare
- test for views - test for tables - cleanup Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
c8d6359
to
3f14dbe
Compare
Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
Ah seems you found it already. Just to have it mentioned (maybe you figured it out that way as well). The logs + screenshots are uploaded as assets on the cypress run https://github.com/nextcloud/tables/actions/runs/6156012270?pr=533 The logs then also show the composer autoload error |
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
closes #529
closes #528
searching for tables was missing 🙄