Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API spec #631

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Improve API spec #631

merged 6 commits into from
Nov 2, 2023

Conversation

QazCetelic
Copy link
Contributor

  • Added the missing properties from API (v1) response differs from API (v1) schema #629.
  • Specified nullability for some properties based on the jsonSerialize method in the DB models and create/update functions from the associated service.
  • Added regex patterns to createdAt & lastEditAt of Table, Share, Column, View, Row components.
  • Added required properties id & tableId to Row component.
  • Added descriptions to subtype, orderWeight, numberPrefix, numberSuffix.

@datenangebot datenangebot merged commit 4be4441 into nextcloud:main Nov 2, 2023
6 of 7 checks passed
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants