Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: show cropped calendar popup #821

Closed
wants to merge 1 commit into from
Closed

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Feb 4, 2024

Calendar was hidden if the modal wasn't long enough. This PR ensures it isn't cropped.

Before

Screenshot from 2024-02-04 11-45-28

After

Screenshot from 2024-02-04 11-12-31

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@juliusknorr
Copy link
Member

I think this approach would cause the overflow scrolling of modals to break but should not longer be necessary with the migration to the native date time picker with #647

@enjeck
Copy link
Contributor Author

enjeck commented Feb 15, 2024

After #647, we no longer need this :)

@enjeck enjeck closed this Feb 15, 2024
@enjeck enjeck deleted the enh/calendar-cropped branch February 15, 2024 23:31
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants