Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish table header and text column rendering #883

Merged
merged 2 commits into from
Mar 4, 2024
+17 −3
Merged

Polish table header and text column rendering #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5c2188
fix: Limit max width of text columns and properly style them
juliusknorr Feb 29, 2024
495ad70
fix: Properly center align the search/add row button
juliusknorr Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/shared/components/ncTable/partials/TableCellEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ export default {
}
</script>

<style scoped>
<style lang="scss" scoped>

div {
max-width: 670px;
max-height: calc(var(--default-line-height) * 6);
overflow-y: scroll;
min-width: 100px;
Expand All @@ -44,10 +45,20 @@ div {
}

:deep(.text-editor__wrapper div.ProseMirror) {
padding: 0px 0px 0px 0px
padding: 0px 0px 0px 0px;

}

:deep(div[contenteditable='false']) {
background: transparent;
color: var(--color-main-text);
width: auto;
min-height: auto;
opacity: 1;
font-size: var(--default-font-size);
}

:deep(.editor__content) {
max-width: 100% !important
max-width: 100% !important;
}
</style>
1 change: 1 addition & 0 deletions src/shared/components/ncTable/sections/CustomTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ export default {

td, th {
padding-right: 8px;
max-width: 500px;
}

td .showOnHover, th .showOnHover {
Expand Down
2 changes: 2 additions & 0 deletions src/shared/components/ncTable/sections/Options.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,12 @@ export default {
.actionButtonsLeft {
display: inline-flex;
align-items: center;
padding-left: calc(var(--default-grid-baseline) * 1);
}

:deep(.actionButtonsLeft button) {
min-width: fit-content;
margin-top: 5px;
}

.searchAndFilter {
Expand Down
Loading