fix(OpenApi): resolve errors and generate openapi file #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
juliusknorr
reviewed
Mar 12, 2024
There was a problem hiding this comment.
Looks good, would be nice to check if the file is up to date as we talked about earlier
https://github.com/nextcloud/spreed/blob/6e8aaa29b0074c0c76c9606113e5cbdebfdd7c8a/.github/workflows/openapi.yml#L61 for inspiration
blizzz
force-pushed
the
fix/noid/openapi
branch
from
2b6e4fb to
7921a25
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
juliusknorr
reviewed
Mar 12, 2024
| id: check_typescript_openapi | ||
| uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0 | ||
| with: | ||
| files: "src/types/openapi/openapi*.ts" |
There was a problem hiding this comment.
We don't have that (yet), but let me quickly check how talk does it, maybe we can adapt it as well for #799
There was a problem hiding this comment.
Aye, it was optional for the check however.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
approved these changes
Mar 12, 2024
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer run openapi was not running through