-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced all the Toasts with Snackbar #3257
Conversation
@AndyScherzinger could you please review this and let me know the changes |
Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>
LGTM @Smarshal21 only a few things:
feel free to fix this or let me know if i should take over |
Manifest.permission.POST_NOTIFICATIONS | ||
) != PackageManager.PERMISSION_GRANTED | ||
) { | ||
// TODO: Consider calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
created issue #3266
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch @Smarshal21
if you like, feel free to implement in follow up PR's.
if you do, please note onRequestPermissionsResult is deprecated, see
https://developer.android.com/training/permissions/requesting
FIxed |
@Smarshal21 you were invited to the nextcloud android team so now you should e.g. be able to create pull requests right inside the nextcloud repo if you would like to |
@Smarshal21 i saw you already posted as guest on our nextcloud org instance. |
@mahibi I did it without asking :S Sorry if that isn't okay for you @Smarshal21 🙏 |
No worries 😀 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Replaced all the Toasts with Snackbars.
🏁 Checklist