Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced all the Toasts with Snackbar #3257

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Conversation

Smarshal21
Copy link
Member

Replaced all the Toasts with Snackbars.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@Smarshal21
Copy link
Member Author

Smarshal21 commented Aug 19, 2023

@AndyScherzinger could you please review this and let me know the changes

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>
@mahibi
Copy link
Collaborator

mahibi commented Aug 23, 2023

LGTM @Smarshal21
thank you 👍

only a few things:

  • an import is missing: OutcomingLocationMessageViewHolder.kt:86:68 Unresolved reference: ColorRole
  • Codacy Static Code Analysis complains a lot about "Exceeded max line length"

feel free to fix this or let me know if i should take over

Manifest.permission.POST_NOTIFICATIONS
) != PackageManager.PERMISSION_GRANTED
) {
// TODO: Consider calling
Copy link
Collaborator

@mahibi mahibi Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
created issue #3266

Copy link
Collaborator

@mahibi mahibi Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch @Smarshal21
if you like, feel free to implement in follow up PR's.
if you do, please note onRequestPermissionsResult is deprecated, see
https://developer.android.com/training/permissions/requesting

@Smarshal21
Copy link
Member Author

LGTM @Smarshal21 thank you 👍

only a few things:

  • an import is missing: OutcomingLocationMessageViewHolder.kt:86:68 Unresolved reference: ColorRole
  • Codacy Static Code Analysis complains a lot about "Exceeded max line length"

feel free to fix this or let me know if i should take over

FIxed

@mahibi mahibi merged commit 3abd7b6 into nextcloud:master Aug 23, 2023
9 of 14 checks passed
@AndyScherzinger AndyScherzinger added this to the 17.1.0 milestone Aug 23, 2023
@mahibi
Copy link
Collaborator

mahibi commented Aug 25, 2023

@Smarshal21 you were invited to the nextcloud android team so now you should e.g. be able to create pull requests right inside the nextcloud repo if you would like to

@mahibi
Copy link
Collaborator

mahibi commented Aug 28, 2023

@Smarshal21 i saw you already posted as guest on our nextcloud org instance.
If you like to have an account there, just ping me there to let me know your email address so i can invite you.

@AndyScherzinger
Copy link
Member

@mahibi I did it without asking :S Sorry if that isn't okay for you @Smarshal21 🙏

@Smarshal21
Copy link
Member Author

@mahibi I did it without asking :S Sorry if that isn't okay for you @Smarshal21 🙏

No worries 😀

Copy link
Contributor

github-actions bot commented Apr 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants