Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decreased the Icon size in notification bar #3275

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

Smarshal21
Copy link
Member

@Smarshal21 Smarshal21 commented Aug 25, 2023

fix #2945

before:
grafik

after:
grafik

Decreased the icon size by 13 percent.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@Smarshal21
Copy link
Member Author

@mahibi could you please confirm if the icon size is still larger and let me know the changes
as i cant test the notification as a developer

@mahibi
Copy link
Collaborator

mahibi commented Aug 25, 2023

@mahibi could you please confirm if the icon size is still larger and let me know the changes as i cant test the notification as a developer

this doesn't change the size for the notification icon but for the login screen, which is not what we want.
i'm not sure if there is an easy way to change it for notifications.
@AndyScherzinger iirc we had this topic earlier, can you remember?

@Smarshal21
Copy link
Member Author

Smarshal21 commented Aug 25, 2023

@mahibi could you please confirm if the icon size is still larger and let me know the changes as i cant test the notification as a developer

this doesn't change the size for the notification icon but for the login screen, which is not what we want. i'm not sure if there is an easy way to change it for notifications. @AndyScherzinger iirc we had this topic earlier, can you remember?

ig that changes both the logo in login screen and in the notification bar
Screenshot 2023-08-25 at 3 56 03 PM
ptal at the above code
am i right?

@AndyScherzinger
Copy link
Member

Afaik the easiest way would be to add some 'padding' to the logo vector itself.

That would slightly resize the login image and the notification icon and is probably fine.
Else we would need 2 distinct vector graphics which just makes life harder for brandings.

@Smarshal21
Copy link
Member Author

Afaik the easiest way would be to add some 'padding' to the logo vector itself.

That would slightly resize the login image and the notification icon and is probably fine. Else we would need 2 distinct vector graphics which just makes life harder for brandings.

Done @AndyScherzinger
ptal

@mahibi mahibi merged commit b2d8981 into nextcloud:master Aug 30, 2023
12 of 13 checks passed
@mahibi
Copy link
Collaborator

mahibi commented Aug 30, 2023

great @Smarshal21 👍

@mahibi mahibi added this to the 17.1.0 milestone Aug 30, 2023
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon in notification bar is too large
3 participants