Added Unit Test For UserIdUtils

[Smarshal21]

fixes #3279

Added Unit Test For UserIdUtils

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[Smarshal21]

@mahibi @AndyScherzinger as we had a chat i have started the writing tests by writing a simple unit test
could you ptal and let me know

[AndyScherzinger]

@Smarshal21 I added some minor comments. On top of that it would be nice if you could add a Github action to execute the tests. For inspiartion see https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml while that would need to be rewriten since you won't have jacoco and the comment deletion. So a simple execution should be enough, like a modified version of https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml#L32-L35 with a different, fitting value for https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml#L35

[AndyScherzinger]

Also @Smarshal21 since we added you to the organization you can just create the branches within this repository. This makes your life and ours easier since rebases are a bit simpler and all GH actions will get executes since that is blocked on forks for security reasons.

[Smarshal21]

Also @Smarshal21 since we added you to the organization you can just create the branches within this repository. This makes your life and ours easier since rebases are a bit simpler and all GH actions will get executes since that is blocked on forks for security reasons.

Sure

[Smarshal21]

@Smarshal21 I added some minor comments. On top of that it would be nice if you could add a Github action to execute the tests. For inspiartion see https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml while that would need to be rewriten since you won't have jacoco and the comment deletion. So a simple execution should be enough, like a modified version of https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml#L32-L35 with a different, fitting value for https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml#L35

Yeah Thanks!!
Will resolve them

[Smarshal21]

Done

[Smarshal21]

@Smarshal21 I added some minor comments. On top of that it would be nice if you could add a Github action to execute the tests. For inspiartion see https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml while that would need to be rewriten since you won't have jacoco and the comment deletion. So a simple execution should be enough, like a modified version of https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml#L32-L35 with a different, fitting value for https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml#L35

could you tell me more about the github actions??

[AndyScherzinger]

could you tell me more about the github actions??

@Smarshal21 anything specific besides the referenced workflow files?

[AndyScherzinger]

Sorry for the late reply, very busy these days :/

[Smarshal21]

could you tell me more about the github actions??

@Smarshal21 anything specific besides the referenced workflow files?

Nope
I wanna clarify about what else i have to include in this pr so that i can get an idea to write other tests as well

[Smarshal21]

Sorry for the late reply, very busy these days :/

Thats fine :)

[AndyScherzinger]

I wanna clarify about what else i have to include in this pr so that i can get an idea to write other tests as well

nothing else I would say :) Better to keep the PRs small that helps with keeping reviews short and merges happening quickly 👍

Also one thing for the future, git related, to keep the PR clean and tidy, best to rebase it against master so you donÄ't have these additional merge commits 😃

[mahibi]

i guess there was some confusion about the suggested github workflow.

The test itself is absolutely fine @Smarshal21 so i merged it.

Adding the github workflow is unrelated. It is about executing all tests on github, see https://docs.github.com/en/actions/using-workflows/triggering-a-workflow for explanation.
i am also not very familiar with it yet so i don't know off the top of my head what exactly is needed from https://github.com/nextcloud/android/blob/master/.github/workflows/unit-tests.yml
e.g. what has to be changed in uploadReport.sh etc..

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!