Remove EntryMenuController and OperationMenuController #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
force-pushed
the
refactor/noid/replaceEntryMenuController
branch
3 times, most recently
from
0677a7d to
27563a2
Compare
mahibi
changed the title
mahibi
force-pushed
the
refactor/noid/replaceEntryMenuController
branch
2 times, most recently
from
8c6a99c to
c135c0e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Fine for now, for a future version let's shorten the text by removing the conversation name but adding an UNDO action - like GMail does for delete/archive |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The "operation view" at the bottom is replaced by snackbars. I have removed the join via public link feature for now. This was buggy, complex and incomplete. This feature must be reimplemented in a more useful place (login screen, so you can use it as a guest without using an existing instance). Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
refactor/noid/replaceEntryMenuController
branch
from
b331c74 to
2975f6d
Compare
|
@AndyScherzinger |
Signed-off-by: github-actions <github-actions@github.com>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3313-talk.apk |
AndyScherzinger
approved these changes
Oct 10, 2023
delete-merged-branch
bot
deleted the
refactor/noid/replaceEntryMenuController
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes EntryMenuController and OperationMenuController, see #1551.
Remaining controllers are now "only" the ones related to the login process.
The "operation view" at the bottom is replaced by snackbars.
One thing worth mentioning:
I have removed the join via public link feature for now. This was buggy, complex and incomplete.
This feature must be reimplemented in a more useful place (login screen, so you can use it as a guest without using an existing instance, see #261).
Screenshots
UI changes were not the main goal of this PR, but for the sake of completeness here's what's changed UI-wise.
The actions can be triggered via the long click menu in the conversations screen (and Create conversation via Contacts screen)
before
after
🏁 Checklist
/backport to stable-xx.x