Grouping upload notification

[parneet-guraya]

Fix: #2373

What this PR includes?

• Grouping notification
• pushing new notification (when failure) so that the progress indicator (part of the original notification) won't show

🖼️ Screenshots

Record_2024-01-10-02-26-05.mp4

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[parneet-guraya]

Sometimes the first upload notification may show separately from group notification. A little demo to support this fact -->

Basically if second notification is pushed after >=400ms then the first one would be separate and rest of the notifications would be part of group and after this second notification time gap wouldn't matter new notifications would always be part of the group. (See video 1)

If second notification is pushed after <400ms then it would be the part of the group from beginning.

Video 1

Record_2024-01-10-03-24-34.mp4

Video 2

Record_2024-01-10-00-59-25.mp4

You can also see in both of these cases a third notification is pushed after 4 seconds which is always the part of group which shows time gap doesn't matter here.

[rapterjet2004]

Sometimes the first upload notification may show separately from group notification. A little demo to support this fact -->

Yes, I've replicated it too. Is there anything you can do about this? Other than that, it looks good. Just fix the ktlintChecks. You can find them by running this on Windows. Also works for detekt too.

./gradlew ktlintCheck

[parneet-guraya]

Sometimes the first upload notification may show separately from group notification. A little demo to support this fact -->

Yes, I've replicated it too. Is there anything you can do about this?

I think it is more of a behaviour than an issue. As I said if the second notification takes more than 400ms it would show the first one separate and the rest of them will go into group. One thing could be done if our worker can trigger notification quickly then it may solve it. That is on my to-do so will see if that works for us.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	80	80
Errors	8	8

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	112	112
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	139	139

[mahibi]

Sometimes the first upload notification may show separately from group notification. A little demo to support this fact -->

Yes, I've replicated it too. Is there anything you can do about this?

I think it is more of a behaviour than an issue. As I said if the second notification takes more than 400ms it would show the first one separate and the rest of them will go into group. One thing could be done if our worker can trigger notification quickly then it may solve it. That is on my to-do so will see if that works for us.

Can confirm this behaviour but it's okay in my opinion.
Worked for me so will merge..
Also: depending on devices, automatic grouping might already done by android.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3567-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!