Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions no longer rendered out of order #3574

Closed
wants to merge 1 commit into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 12, 2024

Closed PR. Not possible without significantly changing the code. I'll come back to this after I implement a new database schema in #3569

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added bug Something isn't working 3. to review Waiting for reviews feature: 🗨️ chat labels Jan 12, 2024
@rapterjet2004 rapterjet2004 self-assigned this Jan 12, 2024
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8383
Errors88

SpotBugs

CategoryBaseNew
Bad practice66
Correctness88
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139139

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3574-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch
Copy link
Contributor

When uploading two large files of the same size, alongside smaller files of varying sizes, doesn't attach caption to the last file in the chat.

- Created a kind of proto-group of files, by injecting JSON with the caption
- Works but not ideal. Planning on replacing solution when implementing new database schema

Signed-off-by: Julius Linus <julius.linus@nextcloud.com>
@rapterjet2004 rapterjet2004 force-pushed the file-captions-improperly-rendered branch from ecb8598 to 20906ec Compare February 2, 2024 18:39
@rapterjet2004 rapterjet2004 added 2. developing Work in progress low Low priority and removed 3. to review Waiting for reviews labels Feb 5, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working feature: 🗨️ chat feedback-requested low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Captions render out of order
2 participants