Feature/edit messages

[sowjanyakch]

Resolves #3509

• Editing a message in a group of messages split the group at the edited message.
• After completing edit or aborting it, it should resume the previous input.
• Edit in default input showing the original content as a "quote"
  • Don't allow changing from message to caption and vice-versa
  • Don't allow to toggle silent send on
• System message hidden like with delete?
• Visible indicator a message was edited (and by whom/when)?
  • Amend to the author name (edited) / (edited by moderator-name)
  • Editor+Time in Message menu as subline of timestamp
• Time limitation like for delete?
  • Limit editing to X hours (draft 24 hours, check what others do and discuss again)
  • Set the limit on deletion to infinite
• What to do about mention notifications (added a mention, removed a mention)?
  • Should indicate in the UI what happens (only when affected)
  • Make sure people don't get 1 for the message and 2 for followup edits
• What about bots?
  • Can not edit bot messages, moderators can
  • Bots will not get explicitly notified about previous edits (only with the default system message)?
  • If a message triggered a bot already it's yolo and will not be retriggered with the new content automatically (bot can do based on the system message?)
    • Should indicate in the UI what happens (only when affected)

🖼️ Screenshots

🚧 TODO

• Ref ✏️ Edit message - Android #3509

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

message editing itself works good already 👍 👍

apart from the other things you're already working on, just some notes:

• add error message to onError (log, and snackbar for UI)
• hide edit message option from menu for message types other than textmessages (location, voice message , ...)
• hide file attachment icon when being in editing mode
• modify color of the checkmark icon to respect dark/light mode. for example change ic_check_24.xml to:

<!--
    @author Google LLC
    Copyright (C) 2021 Google LLC

    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.
    You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
-->
<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:width="24dp"
    android:height="24dp"
    android:viewportWidth="24"
    android:viewportHeight="24"
    android:tint="?attr/colorControlNormal">
    <path android:fillColor="@color/fontAppbar" android:pathData="M9,16.17L4.83,12l-1.42,1.41L9,19 21,7l-1.41,-1.41z"/>
</vector>

• change color for "Edit Message text", pen icon, X icon. i'm not sure about the colors yet. maybe grey?
• the checkmark icon to send the editied message should be themed, like the send button in normal mode.
  just have a look in themeMessageInputView how it's done for other components.
  you get a feeling for theming when you change color theme in web:
  
  then you should recognize that the mobile app also changes colors.
  Components in the android app can be adapted for themeing by using the ViewThemeUtils.
  Just compare how it's done for other components in themeMessageInputView()
• lint warnings are increased (see github report, you can click on "master" and "PR" to compare)
• Formatting in NcApi.java went wild somehow. best is to revert his and only change the lines for this PR.

just let me know in chat if we should have a look together for any topic..

[mahibi]

i suggest to move "edited" before the checkmark? like:
Test2 10:19 (edited) ✔️

and also apply the same color to the "(edited)" like for the time

[mahibi]

• reminder to myself: branch off stable-18.1.0 before merge this PR

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	80	84
Errors	8	8

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	8	8
Dodgy code	112	112
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	139	139

Lint increased!

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3608-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.