Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3532/federated invitation handling #3653

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Feb 21, 2024

resolve #3532

๐Ÿ–ผ๏ธ Screenshots

federation_invitations_20240221.mp4

Opening the room etc will be done in seperate PR's, so opening the conversation list after accepting the invite is fine for now.

How to test (for now)

  1. have 2 users on sermo e.g. userA and userB
  2. login with userA on web
  3. login with userB on android (make sue push messages can be received)
  4. as userA on web:
  • create a new group conversation without users
  • add userB as federated user (see "Add federated users" section):
    Bildschirmfoto vom 2024-02-23 09-47-01 geaendert

on android the invitation should pop up as push message. As long the invite is not accepted, reloading the conversation should show the infobox.

To test the badge for the account switcher while an invitation is pending, there must be added another nextcloud instance on android.

๐Ÿ Checklist

  • โ›‘๏ธ Tests (unit and/or integration) are included or not needed
  • ๐Ÿ”– Capability is checked or not needed
  • ๐Ÿ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • ๐Ÿ“… Milestone is set
  • ๐ŸŒธ PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Feb 21, 2024
@mahibi mahibi added this to the 19.0.0 milestone Feb 21, 2024
@mahibi mahibi force-pushed the feature/3532/federatedInvitationHandling branch from 79e8fb8 to 7c38f96 Compare February 21, 2024 16:20
@mahibi mahibi force-pushed the feature/3532/federatedInvitationHandling branch from 3ede14d to b7fc2e1 Compare February 21, 2024 16:37
@mahibi mahibi added the 3. to review Waiting for reviews label Feb 21, 2024
@mahibi mahibi force-pushed the feature/3532/federatedInvitationHandling branch from b7fc2e1 to 1cc15ed Compare February 23, 2024 14:38
@rapterjet2004 rapterjet2004 added the feature: ๐ŸŒ federation Support for federated conversations label Feb 23, 2024
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the feature/3532/federatedInvitationHandling branch from 1cc15ed to c13f258 Compare February 26, 2024 15:46
@mahibi mahibi merged commit 4ff8b16 into master Feb 26, 2024
13 of 16 checks passed
@mahibi mahibi deleted the feature/3532/federatedInvitationHandling branch February 26, 2024 15:47
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings7979
Errors88

SpotBugs

CategoryBaseNew
Bad practice66
Correctness89
Dodgy code112109
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139137

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3653-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: ๐ŸŒ federation Support for federated conversations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๐ŸŒ Federated invitation handling ๐Ÿ’Œ - Android
2 participants