Fix: File Attachment Preview Dialog crashes ChatActivity

[parneet-guraya]

Fixes: #3572

🖼️ Screenshots

Before

Record_2024-02-29-17-19-09.mp4

After

Record_2024-02-29-17-17-33.mp4

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[parneet-guraya]

Hi @mahibi, could you give it a look?

The reason for crashing was that this dialog fragment does not have a default constructor. So, when config changes occured the activity does not know how to initialize a parameterized constructor and looks for empty constructor, hence the crash. Instead use empty constructor with arguments passed to it as bundle.

I have seen some more fragment implementations like this, will create an issue for that and fix it.

[parneet-guraya]

@mahibi, Also I'm doubtful about using scroll view in a dialog. The buttons were going out of the screen when in landscape mode, so I added the scroll view. Let me know if it's correct to use it here.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	81	81
Errors	10	10

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	9	9
Dodgy code	111	111
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	139	139

[mahibi]

👍

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3674-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!