Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for all parameter in leave call endpoint #4386

Merged
merged 24 commits into from
Nov 12, 2024
Merged

Add support for all parameter in leave call endpoint #4386

merged 24 commits into from
Nov 12, 2024

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Oct 25, 2024 •
edited
Loading

Resolve #4271

One-to-one:

Short/Normal press: "End call" ("End call for everyone")
Long press: "Leave call"

Group:

Short/Normal press: "Leave call"
Long press: "End call for everyone"

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the implement_Short_long_press_options branch 2 times, most recently from bab1393 to a2e13ac Compare October 25, 2024 13:21
@sowjanyakch sowjanyakch marked this pull request as ready for review October 25, 2024 18:16
@sowjanyakch sowjanyakch self-assigned this Oct 25, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Oct 25, 2024
@sowjanyakch sowjanyakch force-pushed the implement_Short_long_press_options branch from b524ac6 to 2975392 Compare October 29, 2024 12:59
@sowjanyakch sowjanyakch force-pushed the implement_Short_long_press_options branch 2 times, most recently from 85f7864 to 2464f63 Compare November 8, 2024 15:36
@nickvergessen
Copy link
Member

What's the status here?

@sowjanyakch @mahibi
Add support for all parameter in leave call endpoint
52fd3f9 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
implement long click and short click on hangup button
ed9fc18 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add button for end call for everyone
ca0533a 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add bundle keys for one-one conversation
9537a8d 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
git bundle keys for group conversation
6e2fdcb 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add short press and long press options to group conversation
3a6a1ed 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add short press and long press options to 1:1 conversation
3d536c2 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
handle end call button
bf3ed0e 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
ktlintFormat
be9bda7 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
ktlintFormat
d523f12 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
modify string
a25f83c 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
implement material button
dff2284 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
set bundle keys in CallNotificationActivity
e5789c0 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
sowjanyakch and others added 11 commits November 12, 2024 12:11
@sowjanyakch @mahibi
ktlintFormat
de63787 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
remove isGroupConversation variable
cfe83dd 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
remove isGroupConversation variable
d09b7b5 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
set "all" parameter to false and set to null only before API call
90628c3 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
show popup for leaving call in 1:1
0920029 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
use touch listeners for hiding popup button
eda9b94 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
use white background for popup button and formatting
121e77b 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
use proper names for popup menu
4705d1f 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
suppress warning string format invalid
37c3f35 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi
rename variables and methods
79a8c16 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
remove to set KEY_ROOM_ONE_TO_ONE twice
49c9b3c 
it's set in proceedToCall()

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the implement_Short_long_press_options branch from 1136ea7 to 49c9b3c Compare November 12, 2024 11:12
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4386-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94152
Errors13288

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

@mahibi mahibi added this to the 20.1.0 milestone Nov 12, 2024
@nextcloud nextcloud deleted a comment from sowjanyakch Nov 12, 2024
@mahibi mahibi merged commit 7c750df into master Nov 12, 2024
16 of 18 checks passed
@mahibi mahibi deleted the implement_Short_long_press_options branch November 12, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews backport-request
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

Implement short/long press options for "End call"/"Leave call"
3 participants
@sowjanyakch @nickvergessen @mahibi