Bugfix/noid/archive conversations handle old nc servers #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mahibi , do you have a release date for some the minor version ? There is a lot of "annoying" improvements fixed. :-) |
today or in the next days |
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
only more complex checks should be made in CapabilitiesUtil, just checking a capability should be done directly via hasSpreedFeatureCapability Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Otherwise it would be shown for older NC versions without to be useful Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
For archived conversations, require "-v2". This is done because on server api, "archived-conversations" was already released for 20.0.2 by mistake which should have only be done for 20.1 As it's planned to release android talk 20.0.3 with a fresh master state, the archived conversations feature must be hidden manually, This is done by required "-v2". Either it's served as this in the future or it can be removed for the 20.1.0 release. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
bugfix/noid/archiveConversationsHandleOldNcServers
branch
from
4991bb8
to
1968d43
Compare
rapterjet2004
approved these changes
Nov 11, 2024
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4427-talk.apk |
mahibi
deleted the
bugfix/noid/archiveConversationsHandleOldNcServers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup fix to #4333
hide archive conversation features (archive/unarchive button in conversation info + "archived" label in filters) for NC versions that don't support it.
Important: By commit 1968d43 the feature is disabled until v20.1.0, see commit message..
🏁 Checklist
/backport to stable-xx.x