Migrating Rxjava to coroutines #1 #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sowjanyakch
force-pushed
the
coroutine_1
branch
from
77eb7cc
to
11ea134
Compare
sowjanyakch
changed the title
sowjanyakch
changed the title
sowjanyakch
force-pushed
the
coroutine_1
branch
from
a7c103f
to
b1ca3ca
Compare
mahibi
approved these changes
Nov 18, 2024
|
|
||
| override fun onError(e: Throwable) { | ||
| } catch (e: Exception) { | ||
| withContext(Dispatchers.Main) { |
There was a problem hiding this comment.
it's not the scope of this PR (so should not be done in this PR) and it was already with RxJava:
When something goes wrong and the exception is thrown or onError was triggered, this will result in an endless loop as the preference is set and immediately triggers the readPrivacyFlow again.
|
|
||
| override fun onError(e: Throwable) { | ||
| } catch (e: Exception) { | ||
| withContext(Dispatchers.Main) { |
There was a problem hiding this comment.
same endless loop situation as with read privacy. Not to be solved in this PR
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4437-talk.apk |
|
/backport to stable-20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4410
🚧 TODO
🏁 Checklist
/backport to stable-xx.x