Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/noid/fix email guest whitspaces #4494

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Bugfix/noid/fix email guest whitspaces #4494

merged 5 commits into from
Nov 28, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 27, 2024 •
edited
Loading

followup to #4473
see #4473 (comment)

handle guests without names

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added this to the 20.1.0 milestone Nov 27, 2024
@mahibi mahibi self-assigned this Nov 27, 2024
@mahibi
fix to handle whitespaces for guest avatars
b3b525b 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
fix empty guest names in conversation info list
41927d2 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
fix empty guest names for chat viewholders
b5a84b4 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
fix guests without name in lastMessage view in conversation list
1b6d620 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
fix guests without name for Mention autocomplete
6932ddf 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the bugfix/noid/fixEmailGuestWhitspaces branch from 27f6645 to 6932ddf Compare November 28, 2024 13:31
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4494-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94159
Errors13273

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

Lint increased!

@sowjanyakch
Copy link
Contributor

sowjanyakch commented Nov 28, 2024 •
edited
Loading

Changing the guest’s display name caused it to appear as two different users were messaging, leading to confusion. Can be fixed in a different PR.

Screenshot 2024-11-28 at 16 03 32

@sowjanyakch sowjanyakch merged commit 4cffb5b into master Nov 28, 2024
14 of 18 checks passed
@sowjanyakch sowjanyakch deleted the bugfix/noid/fixEmailGuestWhitspaces branch November 28, 2024 16:16
@mahibi mahibi modified the milestones: 20.1.0, 21.0.0 Nov 28, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Nov 28, 2024

/backport to stable-20.1

@backportbot backportbot bot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

Assignees

@mahibi mahibi

Labels
None yet
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mahibi @sowjanyakch